Damage calculations

[Beefy Kasplant]

In config:

 

What is crit chance? Don't we set that per class/NPC?

 

In damage calculations, what is crit factor?

[jcsnider]

Sounds like a bug report is in order so we can run some sanity checks  

[jcsnider]

Crit chance is how likely any given attack will be deemed critical. 

 

Crit factor is how much the damage will be multiplied by if it’s a crit. 

 

So if crit chance is 75% and crit factor is 2 then 75% of the time you will do double damage.

 

In retrospect each Npc, item, and class should have custom crit chances. 

[Beefy Kasplant]

Just now, jcsnider said:

Crit chance is how likely any given attack will be deemed critical. 

 

Crit factor is how much the damage will be multiplied by if it’s a crit. 

 

So if crit chance is 75% and crit factor is 2 then 75% of the time you will do double damage.

 

In retrospect each Npc, item, and class should have custom crit chances. 

 

 

Okay so that is weird, since we set Crit Chance in the config and we can set it in class editor and NPC editor

We set crit multiplier in config, and then in the formulas its called crit factor? 

[jcsnider]

That makes much more sense. Yeah, the factor/multiplier should be in the config. 

[Beefy Kasplant]

At the moment, the critical hit chance and multiplier can be set in 2 ways (server config and Editors/formula)

 

Which one overrides which one?

 

I tried to test it some, but I feel like the damage calculation is messing up somewhere.

 

At the moment I have the damage formula as: A_Attack

 

Only the damage takes the base damage, the base damage multiplier and then the attack stack still into account. 

 

Also the critical hit chance in config gets overridden by the crit chance in class/NPC editor. So I would suggest getting rid of the config crit chance? Seems only confusing now. 

 

However, when I get a critical hit, it doesnt take the multiplier into account either, Im very confused!