Jump to content
Sign in to follow this  
Shenmue

Untested Multiline Textbox Fix

Recommended Posts

Posted (edited)

Multiline Textbox Fix

 

Description

Like @Lathander said, "it doesn't look like the multi-line textbox was given any love". This mod is here to help on that.

 

Features

Basic features to expect from a text editor including:
Keyboard shortcuts: Ctr+C, Ctr+V, Ctr+A, Ctr+X
Horizontal and vertical scrollbar

 

Issues

Vertical scrollbar doesn't scroll precisely using keyboard directional input if the text has many lines.

The caret (thin black bar) doesn't react precisely to the mouse actions.

Client crashes when trying to paste a text when nothing has been copied
Some json properties are not taken in consideration like the "TextColor" one.

The scrollbar doesn't disappear when erasing the text.

Download latest fixes update.

 

Media

392e0077839b255eed2aa7277588f1de.gif

 

Note

In order to use this mod you have to know how to create a json file by using the code.

Download links in the GitPatch section are up to date with the latest fixes.

Spoiler

Actually, the current multiline text box is not usable as we cannot type multiple lines or create a json with it (preview here). This code is here to help on that. Basically, it generates a label for each line.

 

So there are two new parameters when instancing a multiline textbox: a string for the name of the json file, and a boolean to allow the write permission.

3c77b717b02213196523902d7441e777.png

 

The image below represents a json file generated by the code above. Values inside the green boxes are the ones shared with the text (more precisely the labels). The other ones are not taken in consideration or apply to the text container only.

c9bc110b9818aed2b5c38c57ab41aad5.png

 

GitPatch: V1.2

Download Multiline Textbox Fix

Download zip file with all patches used (separated)

 

Based On

Version 0.6.2.421 (development branch)

 

Last official working commit with the patch

ID: 1a8edc5d

From: lodicolo

Date: 2020-05-28 7:49:22 PM

Message: fix 191: Bag access is done via cached value (#219) ...

Spoiler

To see the history of commits of your branch, right click on your current branch, then on history.

300f12524b20386e65ab084208b29734.png

 

 

Setup

Be sure to be on the latest official working commit with the patch and build your project after installation.

 

How to apply a patch

How to solve patch conflicts

About diffy.org

Edited by Shenmue
New fixes

Share this post


Link to post
Share on other sites
2 minutes ago, jcsnider said:

Do you mind if we ultimately bring this into the main repo? (I haven't looked at the code yet)

 

Sure you can! I wanted to do a pull request but I didn't know if it would be necessary.

 

Go to the GitHub commit

Share this post


Link to post
Share on other sites
1 hour ago, jcsnider said:

By all means please make a PR :)

 

Ok will do so, however I think I will wait maybe 3 days to check if someone find an issue I could easy fix

Share this post


Link to post
Share on other sites

New patch available.

 

issues solved

Pasted text always appear at the end of a line.

Client crashes depending of how the selection is used.

The caret doesn't adapt to the size of the font.

 

You have installed the mod and want to download the update? Click here

All download links in the GitPatch section are up to date.

 

 

Share this post


Link to post
Share on other sites

New patch available.

 

issues solved

Client crashes when trying to paste a text when nothing has been copied
Some json properties are not taken in consideration like the "TextColor" one.

The scrollbar doesn't disappear when erasing the text.

 

You have installed the mod and want to download the update? Click here

All download links in the GitPatch section are up to date.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×
×
  • Create New...